Bugfixes and improvements

[mattpep]

Hi.

I found this gem - thanks so much for the hard work. I've added some extra functionality and done some bugfixes too. I've tried to group my commits into related changes. The commit log should have details, but here's a summary:

Copes with savings accounts. (previously would give a nil deference error) Copes with (well, skips over) Scottish Widows investments. (same nil error) Cope with zero balance (same nil error) Can read further back than just 25 transactions.

I've started moving a big chunk of the transaction parsing into the Account class because that seemed cleaner to me than doing it in the Customer class. The only bit I'm not proud of is the massive chunk of code duplication - but I haven't yet thought of a clean way to read the initial 25 transactions because at that point the Account object hasn't been created.

What're your thoughts?

Thanks,

MattP

[timrogers]

Hi Matt,

Thanks for your time and hard work - I've been on holiday, but I'll get back to you and review this as soon as possible!

Tim Rogers +44 (0)7969 288 259 @timROGERS

On Monday, 18 February 2013 at 01:38, Matt Peperell wrote:

Hi. I found this gem - thanks so much for the hard work. I've added some extra functionality and done some bugfixes too. I've tried to group my commits into related changes. The commit log should have details, but here's a summary: Copes with savings accounts. (previously would give a nil deference error) Copes with (well, skips over) Scottish Widows investments. (same nil error) Cope with zero balance (same nil error) Can read further back than just 25 transactions. I've started moving a big chunk of the transaction parsing into the Account class because that seemed cleaner to me than doing it in the Customer class. The only bit I'm not proud of is the massive chunk of code duplication - but I haven't yet thought of a clean way to read the initial 25 transactions because at that point the Account object hasn't been created. What're your thoughts? Thanks, MattP You can merge this Pull Request by running git pull https://github.com/mattpep/lloydstsb master Or view, comment on, or merge it at: https://github.com/timrogers/lloydstsb/pull/1 Commit Summary ignore vim swap files bug fix: copes with zero balance and savings accounts Added LloydsTSB::Customer.logoff method read transactions from a specified start point bugfix: Cope with SW investments Handle mandatory messages being shown after login Updated documentation, removing references to the bugs I fixed.

File Changes M .gitignore (https://github.com/timrogers/lloydstsb/pull/1/files#diff-0) (1) M README.md (https://github.com/timrogers/lloydstsb/pull/1/files#diff-1) (10) M example.rb (https://github.com/timrogers/lloydstsb/pull/1/files#diff-2) (23) M lib/lloydstsb/account.rb (https://github.com/timrogers/lloydstsb/pull/1/files#diff-3) (134) M lib/lloydstsb/customer.rb (https://github.com/timrogers/lloydstsb/pull/1/files#diff-4) (36)

Patch Links: https://github.com/timrogers/lloydstsb/pull/1.patch https://github.com/timrogers/lloydstsb/pull/1.diff