chart.xkcd icon indicating copy to clipboard operation
chart.xkcd copied to clipboard

[new chart type]: combined chart

Open Dkalugin opened this issue 4 years ago • 3 comments

Issuehunt badges

Hello! Can I build a combined chart like a screenshot? https://tetis-capital.ru/upload/image/chart.png


IssueHunt Summary

Backers (Total: $50.00)

Become a backer now!

Or submit a pull request to get the deposits!

Tips


IssueHunt has been backed by the following sponsors. Become a sponsor

Dkalugin avatar Sep 03 '19 10:09 Dkalugin

@issuehunt has funded $50.00 to this issue.


issuehunt-oss[bot] avatar Sep 04 '19 01:09 issuehunt-oss[bot]

So, I'm planning to make a new Combined.js in the src and then build it as a separate new chart or you want me to re-use the Bar and Line code, is that possible in some way?

rahgurung avatar Sep 05 '19 02:09 rahgurung

@gurrrung Thanks for the interest, I think we should re-use the Bar and Line code in some way, so we won't need to copy-paste code around when the charts changes(e.g. https://github.com/timqian/chart.xkcd/issues/27), but the current implementation of them is not easy to be reused, we may need to refactor the code a little

Suggestions on the refactoring are welcomed

Ref: How chart.js implement mixed type chart https://www.chartjs.org/docs/latest/charts/mixed.html

timqian avatar Sep 05 '19 05:09 timqian