Timo Carlin-Burns

Cool. I can rebase whenever, seems like this is pretty much impossible to merge for now though given that the team doesn't have enough time for my first (almost rotless)...

@thedavidmeister, I have rebased and then re-run the commands on the base, the commit messages now accurately reflect commands run. > @timotree3 if you want to PR tweaking the flags...

@thedavidmeister gotcha, and thanks for the approve! Only one to go... The only difference between the one in that file and the default, is that the file disables style lints....

I'll run the steps again from latest develop and find out!

@thedavidmeister, nope! There are still things that `cargo fix` changes... I've updated the commits to be based on latest develop and use (almost) latest nightly.

Yeah. It's in the commit messages but here ``` $ cargo +nightly fix --clippy -Z unstable-options $ cargo fmt +nightly ``` At ``` $ cargo +nightly -V cargo 1.41.0-nightly (626f0f40e...

The difference between the settings you linked me to and the default clippy settings (which are listed on [the README](https://github.com/rust-lang/rust-clippy/blob/master/README.md)) is that style lints are enabled by default. I looked...

An alternative to running clippy and failing CI if there are warnings, would be to run `cargo fix --clippy` and fail if it would make any changes. That way we...

The `holochain_net` test failure seems spurious as it is entirely related to system time and completely self-contained. The other one I don't understand.

I believe that I implemented your feedback about the doc comments. I think that they've never run because the tests aborted early with the failures on my machine. Of the...