Timo Carlin-Burns

Results 88 comments of Timo Carlin-Burns

For example, like this: https://github.com/holochain/holochain-rust/blob/f294ed3e001644448e1a816044311cc52ae3c8f8/cli/src/cli/chain_log.rs#L19-L24 Would doing them like that address your concern?

@AshantiMutinta I updated this PR, now the only remaining cases where this PR introduces mutability are a few lines before the end of a test. I figure that in blocks...

@zippy thanks! I believe this is once again ready.

Thanks for reviewing this. :-) Let me do my best to explain my thinking about removing the `Drop` implementation for `Instance`. Sorry... I should've given a PR summary that explained...

Neither of those things seem to have anything to do with my change. Maybe a conflict was mis-merged? That would explain the duplicate function. I'll rebase my branch and get...

> Hey @timotree3, it looks like the tests you added in [6ea8fa6](https://github.com/holochain/holochain-rust/commit/6ea8fa63170728a6170f8c26d56638386e2308bf) are passing for develop? I believe that you just got very lucky. The test that was added in...

> @timotree3 can i get more context around what this represents? > > we have clippy running in CI atm, so where do these additional changes come from? Sure! This...

If you start to look at the change list, I think all of them are pretty irrefutably positive. Here are some of the changes I noticed that it made: -...

> what's the exact command that you ran? @thedavidmeister, the commands for each of the commits are their commit message. Edit: the first commit message is wrong actually. Here are...

Thanks for pointing that out. I can confirm that at least some of the changes wouldn't have been skipped (at least unnecessary `clone` which is in `clippy::perf`). Would you like...