happygapi icon indicating copy to clipboard operation
happygapi copied to clipboard

Published 20 hours ago • verified publisher icon timothypratley

simplifies using a random port

Open timothypratley opened this issue 9 months ago • 2 comments

related to #6

timothypratley avatar May 08 '24 05:05 timothypratley

Hi @JohannesFKnauf - this PR serves to make the auth!-test pass (which it does!)

I'd appreciate your opinion on whether this seems like a sensible approach.

timothypratley avatar May 08 '24 06:05 timothypratley

The main issue it addresses is that exchange-code was not being called with the updated redirect_uri including the random port. There still seems to be a problem when trying to use the refresh_token (it seems to always fail, but I'm not sure if this is new behavior or perhaps it just never refreshed correctly in the first place... something for further investigation).

timothypratley avatar May 08 '24 06:05 timothypratley

@timothypratley I just wanted to let you know, that I saw the PR, but couldn't have a look, so far. I plan to look into the PR and give feedback in the next days.

JohannesFKnauf avatar May 11 '24 19:05 JohannesFKnauf

@JohannesFKnauf thanks for the helpful feedback, I've made the changes you recommended and I think it's ready now? What do you think?

timothypratley avatar May 22 '24 22:05 timothypratley

@timothypratley I just had a look at your changes. Looks ready now! I'll go for a test drive with my client code in parti-time soon.

JohannesFKnauf avatar May 26 '24 17:05 JohannesFKnauf

O.K. great, thank you!

timothypratley avatar May 26 '24 19:05 timothypratley