java-gitlab-api icon indicating copy to clipboard operation
java-gitlab-api copied to clipboard

Improve pagination call

Open mysiki opened this issue 6 years ago • 3 comments

Hey, can you improve pagination management ? I use this api for manage many users and many groups, but each call consume "+1" api call ... For each call, you iterate until result are null. So last call is unless, it's just for test than you don't have other page.

It's possible to use 2 methods : 1 - Use the header return, gitlab give some paging information on header, and the next page if exist .. So you can check this header value pour stop iteration . 2 - You have variable "item per page", so just count call return entry Vs item per page. If return count are < item per page, you don't need to call the next page

Hope you can take time on it. :)

mysiki avatar Oct 23 '19 21:10 mysiki

https://docs.gitlab.com/ee/api/README.html#pagination-link-header

mysiki avatar Oct 23 '19 22:10 mysiki

Hi @mysiki, I'd be happy to review/merge a PR but unfortunately don't have the bandwidth at the moment to contribute this change myself

timols avatar Oct 26 '19 23:10 timols

I will be very happy to do this, but i didn't have thé skill for doing that...i will try,maybe

mysiki avatar Oct 27 '19 20:10 mysiki