react-hot-toast icon indicating copy to clipboard operation
react-hot-toast copied to clipboard

Prepare for React 19

Open memark opened this issue 1 year ago • 3 comments

The global JSX type is deprecated in React 18.3 and removed in React 19 RC. This PR changes the code to use the supported React.JSX syntax instead. It also changes from JSX.Element to the supported React.ReactElement.

memark avatar Oct 06 '24 17:10 memark

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-hot-toast ❌ Failed (Inspect) Oct 6, 2024 5:14pm

vercel[bot] avatar Oct 06 '24 17:10 vercel[bot]

What does the Vercel failure mean? Did I break something?

memark avatar Oct 06 '24 17:10 memark

@timolins Would you know how I can troubleshoot the Vercel failure?

memark avatar Oct 13 '24 06:10 memark

@timolins Any comments on this?

memark avatar Oct 25 '24 04:10 memark

I came here to open exactly this PR. Now, I wonder whether I need to switch the toast library...

frontendphil avatar Dec 11 '24 19:12 frontendphil

@frontendphil I already switched to toastify, which is pretty similar and actively maintained. I'll leave this PR open just in case the project comes back to life.

memark avatar Dec 11 '24 20:12 memark

@timolins can you pelase switch to github actions to let contributors see the issue?

This could be good enough I think: https://daiyi.co/blog/pr-previews-for-github-pages/

landsman avatar Feb 17 '25 10:02 landsman