react-hot-toast
react-hot-toast copied to clipboard
timolins
Add dynamic height state (+ add test setup)
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Updated |
|---|---|---|---|
| react-hot-toast | ✅ Ready (Inspect) | Visit Preview | Jul 17, 2022 at 1:58PM (UTC) |
![vercel[bot] avatar](https://avatars.githubusercontent.com/in/8329?v=4 "Published by a pub.dev verified publisher"){kind=small}
size-limit report 📦
| Path | Size |
|---|---|
| dist/index.js | 4.92 KB (+1.91% 🔺) |
| dist/index.mjs | 4.62 KB (+2.25% 🔺) |
| headless/index.js | 1.79 KB (+1.56% 🔺) |
| headless/index.mjs | 1.5 KB (+1.86% 🔺) |
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Am I right in thinking the only thing blocking this is the size-limit check? Anything we can do to help this along?
@themagickoala Indeed, and it feels weird to block it because of it. Wanted to stay true to the "less than 5kb including styles" claim.
There is #217 which would decrease bundle size below 5kb again.
Maybe even won't even hit 5kb as the check returns only 4944 bytes (but still fails?).
That said, I think we'll just merge before blocking it any longer.
Thanks @timolins! Will there be a release going out with this soon? My current solution is to mock the library and test the toast method was called, and I'd love to get back to real userland testing.
Hi @themagickoala – sorry for the delay! I just released 2.4.0-beta.0, which includes those changes. Let me know how it works for you.
Hi @themagickoala – sorry for the delay! I just released 2.4.0-beta.0, which includes those changes. Let me know how it works for you.
Hi @timolins just picked this up today and it looks like this does fix our tests. Thanks so much!
