hyperlayout icon indicating copy to clipboard operation
hyperlayout copied to clipboard

Hyperlayout simply printing out config

Open WoodyWoodsta opened this issue 8 years ago • 27 comments
trafficstars

Hyper version: 1.0.0 OS: Linux (elementary OS Loki)

I have the following in my ./.hyperlayout (a bit verbose, but I intend to add more to it in the future):

{
  "p2lab": [
    {
      "entry": "tab",
      "layout": [
        "gitsub-dir && cd experimental/p2lab",
        {
          "entry": "vertical",
          "layout": [ "gitsub-dir && cd experimental/p2lab && yarn run watch", "gitsub-dir && cd experimental/p2lab && yarn run serve-dev" ]
        }
      ]
    }
  ],
}

When I run hyperlayout p2lab, it simply prints out:

[hyperlayout config]:{"config":{"entry":"tab","layout":[{"entry":"tab","layout":["gitsub-dir && cd experimental/p2lab",{"entry":"vertical","layout":["gitsub-dir && cd experimental/p2lab && yarn run watch","gitsub-dir && cd experimental/p2lab && yarn run serve-dev"]}]}]},"cwd":"/home"}

... and does not effect the defined layout. Am I doing something wrong?

WoodyWoodsta avatar Dec 02 '16 07:12 WoodyWoodsta

I'm not entirely sure why it prints out the config. Are you sure you have hyperlayout inside ~/.hyper.js? It still seems weird since it should detect the missing plugin (never tested it on Linux, though).

If that issue is fixed it still fails since the config is not correct. It should look like this:

{
  "p2lab": [
    "gitsub-dir && cd experimental/p2lab",
    [[
      "gitsub-dir && cd experimental/p2lab && yarn run watch",
      "gitsub-dir && cd experimental/p2lab && yarn run serve-dev"
    ]]
  ]
}

Since you set the entry point to tab you can leave it out, since this it's the default anyway. entry only works on root level, so it's necessary to create a nested array for a split view.

timolins avatar Dec 02 '16 13:12 timolins

Ok I understand the syntax now. I also had a trailing comma which should have blown it up.

I'm using what you have posted there and it manipulates the tabs, but not so well. I've simplified the config so that we can see what is going on, and included screenshots of the result below. Note that I am using oh-my-zsh, could that perhaps introduce issues?

{
  "layout-test": [
    "echo one",
    [["echo two", "echo three"]]
  ]
}

First tab appears to do what is required. image

Second tab does not do anything. image

WoodyWoodsta avatar Dec 03 '16 05:12 WoodyWoodsta

Weird. Can't really tell why this happens – I need to test this myself on a linux machine. oh-my-zsh shouldn't cause any troubles (I'm using it myself, and it works fine).

Does a single tab config work for you? It looks like pane-splitting is causing some issues.

[[
  "echo 1",
  "echo 2"
]]
$ hyperlayout

timolins avatar Dec 03 '16 12:12 timolins

Splits, but does not execute the second command.

image

WoodyWoodsta avatar Dec 03 '16 13:12 WoodyWoodsta

Okay, thanks for your help! I will try to reproduce this bug, once I get my hands on a linux machine.

timolins avatar Dec 04 '16 14:12 timolins

This is happening to me currently after a fresh install of Hyper on MacOS Sierra.

weedgrease avatar Dec 12 '16 06:12 weedgrease

@kevingelion The thing with the config-printing or commands not executing?

timolins avatar Dec 12 '16 06:12 timolins

The config is just printed and nothing happens. Here's my config:

{
  "devbox": [
    [[
      ["dashboard", "cd ~/Documents/Repositories/dashboard; git status;"],
      ["coreapi", "worker"]
    ]]
  ]
}

weedgrease avatar Dec 12 '16 06:12 weedgrease

@kevingelion Is this still an issue, or has this been resolved in #9?

timolins avatar Dec 12 '16 06:12 timolins

@timolins unfortunately still an issue

weedgrease avatar Dec 12 '16 06:12 weedgrease

Are you using Hyper.app? I could imagine that this happens with Hyperterm.

timolins avatar Dec 12 '16 06:12 timolins

Okay, I think I got the same issue since Hyper 1.0, so I was able to look into it & fix it. 🎉 At least it works for me again. Can someone confirm this?

timolins avatar Dec 13 '16 20:12 timolins

@kevingelion @WoodyWoodsta

timolins avatar Dec 13 '16 20:12 timolins

So I actually noticed now that, even with your example .hyperlayout from the README with printing Hello and World, that only the first command will get run. So I'll type hyperlayout in bash, and the first pane will echo Hello, then the second pane will open but nothing will happen. I can continue adding panes and it still gets to the second and stops. Should I open another issue?

weedgrease avatar Dec 14 '16 01:12 weedgrease

Updated hyperlayout and hyper and tried the simple test as below:

[[
  "echo 1",
  "echo 2"
]]

It's still splitting the window correctly, but both commands are being run in the first pane.

Edit: Tried the above again and it worked fine :smile:. It also worked with a more complicated config. Unsure as to why it did not work correctly the first time.

WoodyWoodsta avatar Dec 14 '16 05:12 WoodyWoodsta

Great! 👍 Does anyone of you remeber why the original Issue (Printing out the raw config) happend? Still seems to be a problem according to #12

timolins avatar Dec 14 '16 06:12 timolins

Unfortunately I did not get to the bottom of that. If I had the time, I would dig into the module and try and find out :frowning_face:

WoodyWoodsta avatar Dec 14 '16 10:12 WoodyWoodsta

I have a fix which I could test on my Windows 10 machine. I'll submit a PR and then someone else can test it on a Mac/Linux :)

Submitted Add more robust method to retrieve config JSON from the terminal

stereokai avatar Dec 14 '16 12:12 stereokai

I accidentally added a broken linked to the PR but fixed it now.

stereokai avatar Dec 19 '16 17:12 stereokai

I've had the same issue (printing the config) and restarting Hyper fixed the issue

jonaswindey avatar Feb 13 '17 14:02 jonaswindey

I have currently the issue (printing the config).

Windows 7 SP1 Hyper 1.3.1 zsh (with babun http://babun.github.io/)

~/.hyperlayout [[ "echo 1", "echo 2" ]]

❯ hyperlayout [hyperlayout config]:{"config":{"entry":"tab","layout":[["echo 1","echo 2"]]},"cwd":"C:\Users\cyril.moreau"}

  • I set an env var in Windows config (TERM_PROGRAM: Hyper)
  • I installed the plugin like this :
    • npm i -g hyperlayout
    • hpm i hyperlayout

Cycymomo avatar Apr 25 '17 09:04 Cycymomo

I can replicate the "printing out config" issue on Windows 7, by typing hyperlayout right after installing the plugin. After restarting hyper though it's gone.

I still have trouble getting hyperlayout to work though... after typing hyperlayout the window just freezes, and dev tools throws a syntax error about unexpected token in JSON.

image

edit Fixed by implementing this https://github.com/timolins/hyperlayout/pull/16 by hand solved everything for me.

RikardGehlin avatar Jun 14 '17 11:06 RikardGehlin

Also fixed by implementing this #16 by hand. Would be nice to get that merged.

edit Implementing that by hand causes freezing issues with certain commands.

jondcoleman avatar Sep 13 '17 22:09 jondcoleman

The original issue seems solved. Is this still that?

philoserf avatar Jan 06 '18 06:01 philoserf

Still happening on Windows 7 x64 with Hyper 2.0.0 - the same .hyperlayout file works fine on linux and macos (hyperlayout 0.2.1)

alexhochreiter avatar Apr 20 '18 04:04 alexhochreiter

I have the same issue, Windows 10 Hyper 2.0.0. When I run hyperlayout all I get is hyperlayout config]:{"config":{"entry":"tab","layout":[["echo 'Hello'","echo 'World'"]]},"cwd":"C:\\Users\\ScriptPup"}

My .hyperlayout file is very simple

[
  [
    "echo 'Hello'",
    "echo 'World'"
  ]
]

ScriptPup avatar Jun 21 '18 20:06 ScriptPup

Same Issue with Hyper v3

tuchk4 avatar Sep 26 '19 20:09 tuchk4