redex-plugin icon indicating copy to clipboard operation
redex-plugin copied to clipboard

Complete support for this

Open jjhesk opened this issue 8 years ago • 7 comments

Are there anyways that u can prebuild or wrap the redex package inside this redex plugins? Because we are using windows... many thanks..

jjhesk avatar May 04 '16 11:05 jjhesk

I guess this is tracked in https://github.com/facebook/redex/issues/18

meoyawn avatar May 08 '16 04:05 meoyawn

Sorry for not replying to this sooner, my email filter must have hidden your issue. Installing Redex and all its dependencies is quite a complex task (especially for multiple platforms) which I unfortunately dont have the time for. And its probably beyond what the plugin should be doing anyway

timmutton avatar May 31 '16 09:05 timmutton

Though we (redex) still don't support windows (yet), we are planning on putting redex binaries on maven (or similar) soon. We also plan for this gradle plugin to pull down a redex binary from the repository. This will avoid the need to build from source for most users.

justinjhendrick avatar Oct 05 '17 20:10 justinjhendrick

Started the downloading work on this branch https://github.com/justinjhendrick/redex-plugin/tree/download_redex. It's a work in progress, but early comments are welcome.

justinjhendrick avatar Nov 01 '17 03:11 justinjhendrick

@justinjhendrick I may be reading this wrong, but your branch downloads the latest redex to the build dir of this project, it doesnt actually download it to the build dir of the project thats using this plugin

timmutton avatar Nov 01 '17 03:11 timmutton

@timmutton, you're right... How do I put it in the project using the plugin's build dir?

justinjhendrick avatar Nov 01 '17 17:11 justinjhendrick

I don't know that you can include an executable in a jar. You might have to rework it so that the plugin does the download

Sent with AquaMail for Android http://www.aqua-mail.com

On 2 November 2017 4:09:24 a.m. Justin Hendrick [email protected] wrote:

@timmutton, you're right... How do I put it in the project using the plugin's build dir?

-- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: https://github.com/timmutton/redex-plugin/issues/1#issuecomment-341171915

timmutton avatar Nov 01 '17 20:11 timmutton