Tim McCormack
Tim McCormack
Before I go too far down this road, does this kind of change look like something you'd be happy with? https://github.com/timmc/lazysodium-java/compare/test-fast-random...more-bounds-checks
I created a PR to add checks: https://github.com/terl/lazysodium-java/pull/95 However, it's failing on what I think is an existing incorrect test or implementation -- could you check it out?
Tests fail on a call to `sodiumPad`, but I think the test may be wrong: https://github.com/terl/lazysodium-java/blob/f7f0025/src/test/java/com/goterl/lazycode/lazysodium/PaddingTest.java#L19-L23 Shouldn't the max buffer length always be less than or equal to the length...
For reference, the `./gradlew test` currently produces this test failure: ``` java.lang.IllegalArgumentException: Provided buffer array length is larger than array at com.goterl.lazysodium.utils.BaseChecker.checkArrayLength(BaseChecker.java:59) at com.goterl.lazysodium.utils.BaseChecker.checkArrayLength(BaseChecker.java:50) at com.goterl.lazysodium.LazySodium.sodiumPad(LazySodium.java:186) at com.goterl.lazysodium.PaddingTest.pad(PaddingTest.java:22) ```
> It wouldn't change the point of whether any particular country has successfully slowed the growth of COVID19 cases @a-lakhani That's actually why it would be a great feature --...
@frsyuki Would it be possible to get some feedback on this PR? I think making this clarification would be very helpful to others considering using this format.
Implementation note: `remove-metric` is not the inverse of `add-metric` since the latter will expand MetricSets into multiple names and metrics. :-( https://github.com/dropwizard/metrics/issues/1007
Given that some software environments conflate bytes and strings, or naively assume ASCII (or well-formed UTF-8, or whatever), I think it makes perfect sense to include byte sequences in here...
There's a `BailErrorStrategy`, but it's a strategy rather than a listener, and it isn't invoked for certain kinds of syntax errors. I've made a tiny runnable example: [Grammar](https://github.com/cavern-social/socialmark/blob/repro-listener/src/main/antlr/Repro.g4): ``` grammar...
Well, if that's what people want, I can only argue so much for the opposite. :-) But that's interesting that this is unexpected -- I'd be happy to try some...