FedoraReview icon indicating copy to clipboard operation
FedoraReview copied to clipboard

Add ada plugin

Open landgraf opened this issue 12 years ago • 3 comments

landgraf avatar Sep 01 '12 18:09 landgraf

Note that our development happens on devel branch, not master branch (as described in CONTRIBUTE file). Current devel branch no longer uses "is_applicable" function in the same way.

But the most important thing is actually, that you duplicated checks already present (CheckLDConfig, CheckSoFiles and few more). I see no reason why that should be done.

So my suggestions for reworking before I can merge:

  1. base this on current devel
  2. remove all non-ada specific checks. If you want to improve checks already in f-r please do it in a different pull request
  3. name all ada checks in sensible and unique way so they won't clash with other checks. My suggestion is "CheckAdaXXX"
  4. If your check is supposed to "override" original check use "deprecates" (see for example RCheckLatestVersionIsPackaged)

sochotnicky avatar Sep 04 '12 08:09 sochotnicky

Ada packages use *.so and ldconfig as well as C++. Why I cannot check LDConfig for ada packages?

landgraf avatar Sep 23 '12 16:09 landgraf

It's actually pretty simple. Checks you duplicated should run for packages that need them automatically already. If you have a package that has *so files and we don't list the ldconfig check, then by all means file a bugreport. With your duplication that test would be listed twice in the resulting template.

I can prepare a branch with fixes I proposed which you could sanity-check, since I am not familiar with Ada guidelines myself.

sochotnicky avatar Sep 23 '12 17:09 sochotnicky