Tim Kendrick

Results 27 comments of Tim Kendrick

Hi there – I only really made this as a proof of concept, so I haven't properly looked into how localization works in monaco. Short answer: localization isn't supported in...

Yep – I plan to get round to this at some point, so I'll keep this issue open.

Hi @Fuji-sunny – sorry for the late reply. This was only meant as an experiment while the Monaco team work on webpack compatibility. There has recently been [a lot of...

@mmun that sounds amazing! My main concern was that HTMLBars would only exist to serve Ember's needs, but it's a great library and I'd love to see it become something...

Explanation of existing incorrect behavior: Existing service provider instantiation does not pass the `EntityID` option: https://github.com/supabase/auth/blob/9a8d0df63bb5089e1705f9d970669bfc97ed345e/internal/api/saml.go#L43-L50 ...which leaves `opts.EntityID` empty in the underlying `DefaultServiceProvider` instantiation: https://github.com/crewjam/saml/blob/346540312f721498fc75e69637d9250dd89f230b/samlsp/new.go#L132-L149 ...so the Entity ID...

I've addressed your feedback @hf - let me know if there's anything else I can do to help get this over the line :)

Any update on whether this PR can be merged? It would be great to get this into the upcoming release if that's possible! Let me know if there's anything I...