Tim Hoffmann

Results 729 comments of Tim Hoffmann

> _basic_ should provide a sane and useful set of defaults. I claim that the sane and useful set of defaults is no styling when taking into account compatibility with...

> Whichever you prefer. The changes to Alabaster will need to be in a PR as it lives at https://github.com/sphinx-doc/alabaster. I'd rather go to separate PRs so that we frist...

Updates: - changed to `context-*` naming. - Added documentation in `html_themes/index.rst` - Rebased onto master to remove conflicts IMHO this is now good-to-go. Ping @AA-Turner, in case you want to...

> By the way: if your local workflow isn't too disrupted by it, it's generally preferable to accumulate commits (including merge commits if necessary to stay up-to-date with the `master`...

> I'm taking a pause here @timhoffm - I'll try to continue this review (and to actually test the suggestions I'm making before adding them, when doing that) later today...

Please make sure this uses as little space as possible. Space in the navigation bar is limited. While I find a dark/light mode setting useful I don’t want to waste...

T.b.d.: This is often used in a context manager: ``` with cbook.get_sample_data('grace_hopper.jpg') as image_file: photo = plt.imread(image_file) ``` It should be simpler to only pass the path to `Image.open()`, which...

Thinking about it, it may be an educational aspect to not hide `PIL.Image.open()` call. It is not obvious how to transfer `get_sample_image()` to your own image file. So ``` photo...

"freeze" is hard to debug. - When you terminate it, do you get a stacktrace? - Have you tried another backend, say `matplotlib.use("qtagg")`? - Have you tried to create a...

To me this feels like YAGNI. Do you have concrete examples where this will help?