Tim

Results 26 comments of Tim

oh, okay, that was my mistake. I reopened it.

I believe this was resolved by https://github.com/cypress-io/cypress-realworld-app/pull/1521 using graphql-http and graphql-playground

sorry for the re-review request. Fixing the `yarn.lock` conflict dismissed the prior review.

This just bit me too. The point of the `===` operator in javascript is that `null === undefined` is *false*. But not for the javascript runtime in appsync. How have...

@MikeMcC399 OK merge conflicts are resolved. Also, in the meantime I discovered https://github.com/cypress-io/cypress-realworld-app/issues/1278 . Indeed this test is passing in firefox after this upgrade to MUI v5. This upgrade was...

I'm unfamiliar with percy but I will try to understand what's going on and see what I can do when I get some free cycles.

OK, I've made some small progress on the TransactionDetail unintended layout change. The offending commit is 552005ba757d366545fb772e9e8c8f524ae99445, resulting from the command: `npx @mui/codemod@latest v5.0.0/preset-safe src`

Looks like [the removal of alignItems and justifyContent props from the Grid component](https://mui.com/material-ui/migration/v5-component-changes/#%E2%9C%85-remove-align-and-justify-props-and-classes) is the problem.

> Looks like [the removal of alignItems and justifyContent props from the Grid component](https://mui.com/material-ui/migration/v5-component-changes/#%E2%9C%85-remove-align-and-justify-props-and-classes) is the problem. Actually, not. My reading of that is that the props are still OK;...

the flex-direction issue looks like it was from a change in the `` component, and a fix is pushed. The font-size issue, and other css issues with text input elements...