ResourcePlaceholdersPlugin icon indicating copy to clipboard operation
ResourcePlaceholdersPlugin copied to clipboard

Add support to AGP 7.3.0

Open extmkv opened this issue 2 years ago • 8 comments

Adding support to AGP 7.3.0.

scrDirectory needs to be added to the variants from the new Variant API.

Resolves #10, resolves #11

extmkv avatar Dec 20 '22 23:12 extmkv

Good job @extmkv. We are facing the same issue as you. I hope that @timfreiheit will be able to process this pull request. Thank you.

jakubjerabek avatar Jan 17 '23 15:01 jakubjerabek

@jakubjerabek I've publish my fork on Gradle Plugins, you can include it and test it in your side.

https://plugins.gradle.org/plugin/pt.jcosta.resourceplaceholders

extmkv avatar Jan 17 '23 15:01 extmkv

@jakubjerabek I've publish my fork on Gradle Plugins, you can include it and test it in your side.

https://plugins.gradle.org/plugin/pt.jcosta.resourceplaceholders

@extmkv Unfortunately my test with your new lib failed (still same behavior). I've contacted you via e-mail from your github profile with details, did you get it? Thank you.

jakubjerabek avatar Jan 24 '23 12:01 jakubjerabek

Which version of AGP are you using in your project?

extmkv avatar Jan 24 '23 12:01 extmkv

We are using 7.3.1.

jakubjerabek avatar Jan 24 '23 12:01 jakubjerabek

@jakubjerabek I've update the plugin to use kotlin 1.8 and AGP 7.4.1 Can you try to bump to version 0.6 and also update AGP and kotlin in your side?

extmkv avatar Feb 02 '23 10:02 extmkv

@extmkv Awesome, it works like a charm again. Thank you so much!

jakubjerabek avatar Feb 02 '23 11:02 jakubjerabek

Great

extmkv avatar Feb 02 '23 13:02 extmkv