timescaledb
timescaledb copied to clipboard
Backport to 2.14.x: #6789: Fix deletes with subqueries and compression
This is an automated backport of #6789: Fix deletes with subqueries and compression. The original issue is #6781. This PR will be merged automatically after all the relevant CI checks pass. If this fix should not be backported, or will be backported manually, just close this PR. You can use the backport branch to add your changes, it won't be modified automatically anymore.
For more details, please see the documentation
Original description
Fix deletes with subqueries and compression
For UPDATEs and DELETEs when a compressed chunk is involved, the code decompresses the relevant data into the uncompressed portion of the chunk. This happens during execution, so it's possible that if the planner doesn't have a plan for the uncompressed chunk then we might miss scanning out on those decompressed rows. We now check for the possibility of a compressed chunk becoming partial during the planning itself and tag on an APPEND plan on top of scans on the compressed and uncompressed parts.
Codecov Report
Attention: Patch coverage is 45.45455%
with 6 lines
in your changes are missing coverage. Please review.
Project coverage is 79.23%. Comparing base (
39616e8
) to head (5508d3a
). Report is 14 commits behind head on 2.14.x.
Files | Patch % | Lines |
---|---|---|
tsl/src/nodes/decompress_chunk/decompress_chunk.c | 45.45% | 5 Missing and 1 partial :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## 2.14.x #6792 +/- ##
==========================================
- Coverage 79.73% 79.23% -0.51%
==========================================
Files 190 189 -1
Lines 37343 35768 -1575
Branches 9483 9011 -472
==========================================
- Hits 29777 28339 -1438
+ Misses 3147 3084 -63
+ Partials 4419 4345 -74
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Hi @nikkhils. When timescaledb team plan 2.14.3 release? Above changes will be here?
Hi @nikkhils. When timescaledb team plan 2.14.3 release? Above changes will be here?
Hi @nikkhils do we have any news regarding 2.14.3 release? Can I still expect that above fix will be in next release?
@Dzuzepppe there's no plan to do a new 2.14.x release. So, this PR will be closed. To get this fix you will need to upgrade to the 2.15.x release.