timescaledb icon indicating copy to clipboard operation
timescaledb copied to clipboard

Use data inheritance from VirtualTupleTableSlot in compressed batch

Open akuzm opened this issue 5 months ago • 2 comments

This simplifies passing the columnar data out of the DecompressChunk to Vectorized Aggregation node which we plan to implement. Also this should improve memory locality and bring us closer to the architecture used in TAM for ArrowTupleSlot.

Disable-check: force-changelog-file

akuzm avatar Feb 07 '24 19:02 akuzm

Codecov Report

Attention: 23 lines in your changes are missing coverage. Please review.

Comparison is base (59f50f2) 80.06% compared to head (af72722) 81.47%. Report is 15 commits behind head on main.

Files Patch % Lines
tsl/src/nodes/decompress_chunk/compressed_batch.c 79.36% 0 Missing and 13 partials :warning:
tsl/src/nodes/decompress_chunk/batch_queue_heap.c 61.53% 0 Missing and 5 partials :warning:
tsl/src/nodes/decompress_chunk/compressed_batch.h 57.14% 0 Missing and 3 partials :warning:
tsl/src/nodes/decompress_chunk/batch_array.c 66.66% 0 Missing and 1 partial :warning:
tsl/src/nodes/decompress_chunk/batch_queue_fifo.h 75.00% 0 Missing and 1 partial :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6615      +/-   ##
==========================================
+ Coverage   80.06%   81.47%   +1.41%     
==========================================
  Files         190      191       +1     
  Lines       37181    36418     -763     
  Branches     9450     9464      +14     
==========================================
- Hits        29770    29673      -97     
+ Misses       2997     2979      -18     
+ Partials     4414     3766     -648     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 07 '24 19:02 codecov[bot]

@mahipv, @jnidzwetzki: please review this pull request.

Powered by pull-review

github-actions[bot] avatar Feb 12 '24 14:02 github-actions[bot]