timescaledb icon indicating copy to clipboard operation
timescaledb copied to clipboard

Backport to 2.13.x: #6567: Properly set job failure on compression policies

Open timescale-automation opened this issue 1 year ago • 2 comments

This is an automated backport of #6567: Properly set job failure on compression policies. This PR will be merged automatically after all the relevant CI checks pass. If this fix should not be backported, or will be backported manually, just close this PR. You can use the backport branch to add your changes, it won't be modified automatically anymore.

For more details, please see the documentation

Original description

Properly set job failure on compression policies

In #4770 we changed the behavior of compression policies to continue compressing chunks even if a failure happens in one of them.

The problem is if a failure happens in one or all the chunks the job is marked as successful, and this is wrong because a failure happens so if an exception occurs when compressing chunks we'll raise an exception at the end of the procedure in order to mark the job as failed.

Disable-check: force-changelog-file

timescale-automation avatar Feb 01 '24 14:02 timescale-automation

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (2.13.x@b50a734). Click here to learn what that means.

Additional details and impacted files
@@            Coverage Diff            @@
##             2.13.x    #6591   +/-   ##
=========================================
  Coverage          ?   82.46%           
=========================================
  Files             ?      249           
  Lines             ?    57983           
  Branches          ?    12928           
=========================================
  Hits              ?    47818           
  Misses            ?     6763           
  Partials          ?     3402           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 01 '24 15:02 codecov[bot]

@fabriziomello can we close this one as its been released with 2.14?

antekresic avatar Feb 12 '24 08:02 antekresic

@fabriziomello can we close this one as its been released with 2.14?

I think this can be closed, no plans to release 2.13.x anymore.

akuzm avatar Feb 19 '24 11:02 akuzm