timescaledb icon indicating copy to clipboard operation
timescaledb copied to clipboard

Account for filters in DecompressChunk row estimates

Open akuzm opened this issue 5 months ago • 2 comments

We don't account for them at all currently, which leads to weird planning behavior, like the filters not influencing the position of relations in join. We don't normally have the statistics on uncompressed tables of compressed chunks, so these estimates will be using the Postgres defaults that are chosen based on the kind of filter.

Disable-check: force-changelog-file

akuzm avatar Jan 24 '24 21:01 akuzm

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (c715d96) 79.73% compared to head (ce2b7cd) 79.70%. Report is 2 commits behind head on main.

:exclamation: Current head ce2b7cd differs from pull request most recent head afcbe74. Consider uploading reports for the commit afcbe74 to get more accurate results

Files Patch % Lines
tsl/src/nodes/decompress_chunk/qual_pushdown.c 66.66% 0 Missing and 1 partial :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6563      +/-   ##
==========================================
- Coverage   79.73%   79.70%   -0.04%     
==========================================
  Files         188      188              
  Lines       36768    36726      -42     
  Branches     9295     9280      -15     
==========================================
- Hits        29318    29271      -47     
- Misses       3112     3126      +14     
+ Partials     4338     4329       -9     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jan 24 '24 22:01 codecov[bot]

@mkindahl, @antekresic: please review this pull request.

Powered by pull-review

github-actions[bot] avatar Jan 25 '24 09:01 github-actions[bot]