timescaledb icon indicating copy to clipboard operation
timescaledb copied to clipboard

Add check function to policies

Open mkindahl opened this issue 2 years ago • 2 comments

This commit adds a check function to the bgw_job table and also create new validation functions for continuous aggregate, reorder, compress, and retention policies.

The checking functions will check that the configuration is semantically correct by reading the necessary fields for each job type and validating that all fields are there and that they have the correct type.

The checking function will be used to check the configuration structure when altering the job using the alter_job function.

Fixes #2895

mkindahl avatar Jun 07 '22 08:06 mkindahl

Codecov Report

Merging #4425 (8177008) into main (1f6d697) will increase coverage by 0.05%. The diff coverage is 95.77%.

:exclamation: Current head 8177008 differs from pull request most recent head ab1fb26. Consider uploading reports for the commit ab1fb26 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4425      +/-   ##
==========================================
+ Coverage   90.77%   90.82%   +0.05%     
==========================================
  Files         224      224              
  Lines       41915    42142     +227     
==========================================
+ Hits        38047    38275     +228     
+ Misses       3868     3867       -1     
Impacted Files Coverage Δ
src/chunk.h 100.00% <ø> (ø)
src/ts_catalog/catalog.h 100.00% <ø> (ø)
tsl/src/init.c 95.45% <ø> (ø)
src/cross_module_fn.c 67.44% <25.00%> (-3.00%) :arrow_down:
src/bgw/job.c 94.58% <99.00%> (+1.43%) :arrow_up:
src/chunk.c 95.10% <100.00%> (+0.59%) :arrow_up:
src/copy.c 94.49% <100.00%> (ø)
src/hypertable.c 86.57% <100.00%> (+0.02%) :arrow_up:
src/nodes/chunk_dispatch.c 95.16% <100.00%> (+0.16%) :arrow_up:
src/nodes/chunk_insert_state.c 97.60% <100.00%> (-0.03%) :arrow_down:
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7c55d0d...ab1fb26. Read the comment docs.

codecov[bot] avatar Jun 09 '22 07:06 codecov[bot]

@svenklemm, @fabriziomello: please review this pull request.

Powered by pull-review

github-actions[bot] avatar Jul 21 '22 13:07 github-actions[bot]