timescaledb icon indicating copy to clipboard operation
timescaledb copied to clipboard

Set statement_timeout for test instances

Open svenklemm opened this issue 2 years ago • 2 comments

This patch sets a 10 second statement timeout so any statement taking longer than that will get canceled by postgres. For our tests no single statement should take longer than that anyway but quite regularly bgw tests get stuck and run into much longer 5 minute timeout imposed elsewhere.

svenklemm avatar May 25 '22 18:05 svenklemm

Codecov Report

Merging #4388 (52b7664) into main (dcb7dcc) will decrease coverage by 0.01%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4388      +/-   ##
==========================================
- Coverage   90.81%   90.80%   -0.02%     
==========================================
  Files         218      218              
  Lines       40324    40324              
==========================================
- Hits        36621    36616       -5     
- Misses       3703     3708       +5     
Impacted Files Coverage Δ
tsl/src/data_node.c 95.40% <100.00%> (+<0.01%) :arrow_up:
src/loader/bgw_message_queue.c 85.52% <0.00%> (-2.64%) :arrow_down:
tsl/src/nodes/data_node_dispatch.c 97.10% <0.00%> (-0.25%) :arrow_down:
tsl/src/bgw_policy/job.c 88.62% <0.00%> (-0.05%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 34bf695...52b7664. Read the comment docs.

codecov[bot] avatar May 25 '22 18:05 codecov[bot]

Even if you want to lower the timeout, 10s seems like a very low timeout.

Agree with @mkindahl 10s is very low timeout.

fabriziomello avatar Jun 17 '22 17:06 fabriziomello