timescaledb-toolkit icon indicating copy to clipboard operation
timescaledb-toolkit copied to clipboard

Published 20 hours ago • verified publisher icon timescale

feat(heartbeat): add average and stddev functions to heartbeat agg

Open ollz272 opened this issue 1 year ago • 3 comments

This would be useful for us to have for our own usage (We want to use the stats on average uptime/downtime to do some more analysis).

Let me know if anymore is needed.

ollz272 avatar Sep 06 '23 18:09 ollz272

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Sep 06 '23 18:09 CLAassistant

Please do cargo fmt so that we have consistent formatting - thanks!

syvb avatar Sep 06 '23 18:09 syvb

Hi @ollz272, very good, I'm not a Rust dev here, but I'm an avid user of toolkit too 🤗

  1. can we add a few more tests just calling the functions and asserting the values?
  2. or at least add it on docs/test_caggs that could cover and exemplify.
  3. We also have this tests/update/heartbeat.md that could include some tests.

We still don't have the docs/heartbeat_agg which would be the right place to document it. Feel free to introduce the file if you think it makes sense.

jonatas avatar Dec 15 '23 14:12 jonatas