promscale icon indicating copy to clipboard operation
promscale copied to clipboard

Promscale should not terminate under non-critical conditions

Open mjf opened this issue 4 years ago • 2 comments

Promscale terminates with error under conditions when one would expect just some log entries. For example when it could not connect to a database (this may be because of many reasons and have simply nothing to do with Promscale as such, i.e. somebody may have deployed new Promscale instance and have not yet configured PostgreSQL role for Promscale for it, or even hasn't created the database yet, or there is pg_hba.conf entry missing etc.). I agree that software in general should terminate if there is a critical configuration error or serious runtime error but I do not agree it should terminate if the other side is just rejecting connections for any reason etc. So what I suggest is to make database connection errors non-critical so that normal connection retries apply. Optionally some option may be provided to influence the behaviour for backward compatibility.

mjf avatar Apr 19 '21 10:04 mjf

I agree we shouldn't terminate on all conditions. It would be better to categorize some as recoverable and some as non-recoverable and then terminal only on non-recoverable and the rest can be a retry.

harkishen avatar Apr 20 '21 12:04 harkishen

closing this issue, as we haven’t received multiple requests from users for this feature and it's quite stale! :)

If you still have a need for this, Please open a new issue.

Thanks!

VineethReddy02 avatar Aug 17 '22 17:08 VineethReddy02