promscale icon indicating copy to clipboard operation
promscale copied to clipboard

Published 20 hours ago • verified publisher icon timescale

Remove helm upgrade logic from promscale connection secret

Open raphaelzoellner opened this issue 3 years ago • 2 comments

Description

This PR adds the preserveConnectionSecret value to allow for a removal of the upgrade logic from the promscale connection secret as suggested in #1474.

By default preserveConnectionSecret is set to true.

If preserveConnectionSecret is set to false this will allow to upgrade the connection secret by a helm upgrade for the release of the promscale helm chart.

raphaelzoellner avatar Jul 06 '22 12:07 raphaelzoellner

This needs a bit more thinking as we currently rely on this mechanism in tobs.

paulfantom avatar Jul 07 '22 08:07 paulfantom

@paulfantom sorry I wasn't aware of the dependency in tobs to this mechanism.

How about introducing a switch to the helm values instead to disable the upgrade logic? I've updated the PR and added a value named preserveConnectionSecret to switch between helm upgrade modes of the secret.

raphaelzoellner avatar Jul 26 '22 12:07 raphaelzoellner