PG16 Issues with Timescale Toolkit

[jon-sully]

Howdy! I've had a hell of a couple of days trying to figure out what all is going on here, and I don't know that I'd even say I have successfully but I at least wanted to post back some notes.

So https://github.com/timescale/homebrew-tap/commit/3727aa74772017bd40e58acad2a0a512b8814eb8 bumped the Postgres version for TimescaleDB itself up to 16. https://github.com/timescale/homebrew-tap/commit/5f635cd4a7b7b123382fe0c3d38d2d536364769e quickly followed since the extension gets compiled as .dylib now, not a .so, and I think those layers work fine — installing Timescale DB via Homebrew on a fresh Homebrew Postgres (16) works fine.

Things do not work when you try to install the Toolkit after that. For starters, the Toolkit formula references PG15 instead of 16 in multiple places:

• https://github.com/timescale/homebrew-tap/blob/5f635cd4a7b7b123382fe0c3d38d2d536364769e/timescaledb-toolkit.rb#L10
• https://github.com/timescale/homebrew-tap/blob/5f635cd4a7b7b123382fe0c3d38d2d536364769e/timescaledb-toolkit.rb#L13
• https://github.com/timescale/homebrew-tap/blob/5f635cd4a7b7b123382fe0c3d38d2d536364769e/timescaledb-toolkit.rb#L27
• https://github.com/timescale/homebrew-tap/blob/5f635cd4a7b7b123382fe0c3d38d2d536364769e/timescaledb-toolkit.rb#L33

And hard-codes for the .so file extension here.

Though perhaps more problematically, the post-install script for the toolkit itself (not this repo) still looks for .so here and here

All of essentially prevent a new install of the Toolkit from running / working at all. 🙁