helm-charts icon indicating copy to clipboard operation
helm-charts copied to clipboard

allow curl image override

Open pitwegner opened this issue 4 years ago • 1 comments
trafficstars

pitwegner avatar Jul 26 '21 11:07 pitwegner

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


pit.wegner seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Jul 26 '21 11:07 CLAassistant

bump - I also noticed this issue, we don't have internet access in our clusters. Was about to open a pull request for this but saw it is already mentioned here

pchang388 avatar Jan 24 '23 21:01 pchang388

@pchang388 looks like the author of this PR might not be responding. @pitwegner if you can sign the CLA bot and rebase from main I can get this PR merged, until then it's most likely in limbo unless someone else comes along to supersede this PR.

nhudson avatar Jan 24 '23 21:01 nhudson

Hi @nhudson - let me try and make a PR then with updated comments in addition to his changes

pchang388 avatar Jan 24 '23 21:01 pchang388

@nhudson - first time trying to contribute to this repo and tried my best to follow the contributers guide, Opened new PR with updated comments and also other changes: https://github.com/timescale/helm-charts/pull/556

Thanks!

pchang388 avatar Jan 24 '23 23:01 pchang388

@nhudson - I had some issues with my email and CLA agreement being signed but finally fixed it, new PR with CLA signed here: https://github.com/timescale/helm-charts/pull/558

pchang388 avatar Jan 24 '23 23:01 pchang388