timeoff-management-application
timeoff-management-application copied to clipboard
ICS all day feed issue with Outlook
I'm seeing the issue that when importing the .ics feed in Outlook all-day events seem to be configured incorrectly. When imported they only show up at 00:00 and are not treated as all day events, making them almost impossible to spot. When looking at the data indeed it uses the same start and end date.
A google/stackoverflow search pointed out that 'according to the spec' the end date needs to be the next day. (https://stackoverflow.com/questions/47151477/ics-file-when-imported-in-outlook-shows-wrong-end-date-when-no-start-end-time) I created a really simple fix for this scenario, but did NOT do any tests with other ics readers or integrations except for Outlook.
For me what solved the issue was changing the/lib/route/feed.js
code for all-day items to this:
if (day.is_leave_morning && day.is_leave_afternoon) {
start.hour(0).minute(0);
end.hour(0).minute(0);
end = end.add(1, 'day');
allDay = true;
}
It might be useful to check this behavior with other integrations and include the fix where necessary.