library upgrade (express, sequelize & co all up2date now), google authenticator, merged title&slack PR

[simllll]

this pr enables login by google auth (via passport).

• it does not create new users, they must be created before hand (the password does not matter in this case though ;))
• you can define which domains are valid - if you have a google work account/domain.
• you can disable the default login

"login": {
    "default": false,
    "google": ["yourdomain.com"]
  },

you must configure google client id and secret (you get that here: https://console.developers.google.com/apis/credentials)

  "google": {
    "clientID": "123",
    "clientSecret": "123"
  },

regards Simon

[simllll]

"breaking" change:

• "ga_tracker": "UA-63733147-1", -> instead of "ga_analytics_on" flag. you can specify your google tracker id here.
• mysql2 is needed instead of "mysql" due to ugprade of sequelize

[simllll]

merged slack and title PRs into it

[simllll]

any feedback on this? is it welcomed to conribute to this project? I'm still running my own fork, due to the lack of google authenticator (which is part of this PR).

Just let me know, and thanks for your work!

Simon

[vpp]

@simllll thank you for contribution and effort to make project better.

Unfortunately I do not have time to properly review the PR.

To merge it as it is is very risky IMHO as the app is in use by many clients so I have to be sure in what goes into master...

The PR contain many very useful things so I am going to use as a base and introduce bits by bits the patches.

Sorry for what could look like arrogant attitude, but there are many users of the app and clients of cloud based solution and the project should be stable...

[simllll]

@vpp thanks, no problem, just wanted to know if it is welcomed in general. If I find some time, I can try to split the PR into several small ones by features if this helps you ;). So far it has following features/fixes in it:

• a lot of library upgrades (sequelize3->4, nodemaler1->4,..etc)
• google authenticator (limit by domain)
• a lot of fixes for analytics & co
• slack and title PR merged (we are not using slack with this anymore though,..), could be done better I guess
• anniversary ical
• fixes for file uploads (restore methods)

thanks for your work!

simon

[vpp]

@simllll thank you for understanding, yes smaller PRs would be much easier to get through.

a lot of library upgrades (sequelize3->4, nodemaler1->4,..etc)

^^ that sounds very interesting to me at this moment

Thank you

[simllll]

hi @vpp, i've started to split the PR up and rebase / refactor it based on the current master. To get things going, and make PRs and commits easier for the future we really need to use some code style guideline. To keep discussion short, I just added prettier (https://prettier.io/) It's a well known code style formatter, which has almost no configurations. Therefore it should be good to go ;). Please consider PR #345. I'm working on #346 in the meantime (library upgrade). And will add Google Login and Anniversy ICAL as the next two PRs. (these features are needed to let me use the master branch ;)).

regards Simon