timeoff-management-application icon indicating copy to clipboard operation
timeoff-management-application copied to clipboard

Published 20 hours ago • verified publisher icon timeoff-management

Adding Slack integration

Open Morthor opened this issue 6 years ago • 13 comments

Added Slack support for TimeOff. Using @slack/client npm module. Added new Slack class based on the email original class. Same for template from email to slack message templates. Added migration to add slack_username field to Users table. Added unit test based on email unit test.

Morthor avatar Mar 29 '18 12:03 Morthor

@Morthor thank you for PR.

That feature was asked many times.

I will have a look at the diff more carefully soon.

vpp avatar Mar 29 '18 13:03 vpp

That's nice to know. Just tell me if anything is missing or needs to be improved.

Regards

Morthor avatar Mar 29 '18 14:03 Morthor

I found an issue with importing employees from csv file. I'm currently fixing it and will commit + push soon.

Morthor avatar Apr 02 '18 12:04 Morthor

I have a commit to fix/add titles to all the pages which are missing them. It's on top of these merges though. So once this is approved I can create a new PR. https://github.com/Morthor/application/commit/f96c996b7dd4aa390ebf20533987316fc0a490e1

Morthor avatar Apr 03 '18 11:04 Morthor

hi guys, this can be added now?

alansoliditydev avatar Apr 20 '18 08:04 alansoliditydev

There are very likely some changes that vpp would like me to make, possibly regarding migrations/schema. I believe my original approach of using migrations was the correct one, but the original instructions for new installations don't mention running migrations so I modified the original schema. But in hindsight that seems like a bad idea for people who just want to update their current version.

I guess vpp is just too busy to review the MR.

Morthor avatar Apr 20 '18 09:04 Morthor

Hi guys, sorry for staying silent in this thread. I am little bit busy those days (for about next 6-7 days) and then I will have a look into this more thoroughly.

I really appreciate this pull request as this is how the app grows its functionality.

Thank you guys for all your input.

Sent from my iPhone

On 20 Apr 2018, at 11:03, Morthor [email protected] wrote:

There are very likely some changes that vpp would like me to make, possibly regarding migrations/schema. I believe my original approach of using migrations was the correct one, but the original instructions for new installations don't mention running migrations so I modified the original schema. But in hindsight that seems like a bad idea for people who just want to update their current version.

I guess vpp is just too busy to review the MR.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

vpp avatar Apr 20 '18 11:04 vpp

Beside slacks; I would love to see webhooks being integrated, which is useful for Slack, but for all other chat(bots) like rocket.chat as well. +1

saschafoerster avatar Jul 26 '19 22:07 saschafoerster

I fully agree with @saschafoerster regarding the webhooks as it would open the gate for other third party system integration. BTW: is there any plan to complete this PR?

attilabalazsy avatar Jul 15 '22 08:07 attilabalazsy

The PR is little bit outdated, but not much, just mechanical issues.

I would be happy to get it into.

vpp avatar Jul 15 '22 08:07 vpp

I must confess I didn't remember this PR was open. It's been 4 years.

Morthor avatar Jul 15 '22 08:07 Morthor

@Morthor , don't worry, I will use this PR as a base.

Conceptually it has all needed for the feature, it just requires some work to fit into the app.

vpp avatar Jul 15 '22 08:07 vpp

Would it be also possible to incorporate the webhooks? We have a third party HR system, where we would like to forward the approved and rejected vacations. If there would be hooks, then we could create a simple hook consumer and forward/remove the needed records. That would be amazing!

attilabalazsy avatar Jul 15 '22 10:07 attilabalazsy