lag-llama icon indicating copy to clipboard operation
lag-llama copied to clipboard

Update requirements.txt

Open ShaneOss opened this issue 1 year ago • 3 comments

bump gluonts version. Previous version use old version of pydantic.

ShaneOss avatar Feb 08 '24 23:02 ShaneOss

@ShaneOss thanks mate! I was thinking of upgrading to lighting instead of pytorch-lightning... what do you think?

kashif avatar Feb 11 '24 20:02 kashif

Hey @kashif , good idea. It works, no issues. Also fixes a few legacy dependency problems.

ShaneOss avatar Feb 11 '24 21:02 ShaneOss

no worries, this week is choka for me but will have a look soon

kashif avatar Feb 12 '24 16:02 kashif

Thanks @ShaneOss. I'd have to check if this causes any problems when training, since we found our version of GluonTS to be the most stable one. Will check it soon.

Regarding lightning, @kashif, that'll require a good amount of refactoring if you want to upgrade: are there any benefits?

ashok-arjun avatar Feb 20 '24 15:02 ashok-arjun

@ShaneOss so we realized that if we require gluonts[torch] as the top level requirement, it pulls in the working versions of lighting and pytorch-lightning so closing this PR for now

kashif avatar Mar 05 '24 13:03 kashif