Tim Cassell

Results 245 comments of Tim Cassell

Well, would you like to open a new issue for it? I don't want to include it in this PR. I can do a followup PR for it if BDN...

Looks like this is already done since https://github.com/dotnet/BenchmarkDotNet/commit/61b3c56d94a4f6f014bb58686f2f19f9268f99cb, right @adamsitnik?

I don't see anything wrong with that code. But I just updated my `AwaitHelper` in #2108 to work for multiple threads, and I wonder if you tried the same thing...

I'm curious why the deadlock only happens with your changes, and not in the existing tests that do the same blocking wait (just without reading the result). By deduction, it...

You added validation here to make sure IterationSetup/Cleanup are not async. I actually added async support for them in #2111, and this seems likely to get merged first, so I'll...

I wonder if that xUnit bug is the cause of the `AllSetupAndCleanupTest` flakiness. :thinking:

> I hope your PRs will be accepted before the Unity moves to .NET Core. Just two years left to wait 😭 Yeah it would be nice to unblock async...

@snowfrogdev Yegor is MIA, feel free to take over here.

For whoever will work on this, it looks like Windows has an escape hatch for very long paths, but it requires parsing the path to make sure it has proper...

I've had an open PR to fix this for a while, it just depends on when @AndreyAkinshin will get around to reviewing it. In the meantime, you can work around...