kbar
kbar copied to clipboard
timc1
feat: :sparkles: allow looping of lists
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Updated |
|---|---|---|---|
| kbar | ✅ Ready (Inspect) | Visit Preview | Jun 26, 2022 at 10:51AM (UTC) |
![vercel[bot] avatar](https://avatars.githubusercontent.com/in/8329?v=4 "Published by a pub.dev verified publisher"){kind=small}
I have updated the part where we determine what should be the next index when we press arrow up and arrow down, I have tried to do a simulation and have mentioned the comments about what each block is doing, @timc1 request you to review this. I have verified it by checking for scenarios like
- allowLoop = true / false and list have section headers
- allowLoop = true / false and list does not have section headers
@benatpigment the project is not being maintained I suppose, the linked issue for this have also being closed by slate bot. 😞
Hey! This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
![stale[bot] avatar](https://avatars.githubusercontent.com/in/1724?v=4 "Published by a pub.dev verified publisher"){kind=small}
Hey @AkashRajpurohit, apologies for the later response!
We previously had looping enabled but decided on removing it for the added complexity. I do not have strong feelings for adding this feature back as it adds a lot more logic in for no real benefit.
I think this can be really beneficial when you have lots of items in the list, and I think there are multiple use-cases where kbar is used under these scenarios.
Plus, this is an opt-in feature and the default behavior still remains as a non looping list. Additionally, I have added comments for future code readers to follow along with this flow.
Hey! This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.