kbar icon indicating copy to clipboard operation
kbar copied to clipboard

fix: don't spread defaultPlaceholder onto input

Open tobiasandersen opened this issue 2 years ago • 1 comments

Currently when passing a defaultPlaceholder prop to <KBarSearch /> it will also spread that prop onto the input element, resulting in the following warning:

react-dom.development.js:67 Warning: React does not recognize the `defaultPlaceholder` prop on a DOM element. If you intentionally want it to appear in the DOM as a custom attribute, spell it as lowercase `defaultplaceholder` instead. If you accidentally passed it from a parent component, remove it from the DOM element.

tobiasandersen avatar Apr 23 '22 10:04 tobiasandersen

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/timc/kbar/HqU6xmc8UFQseGr8LdozZ9ssbP1v
✅ Preview: https://kbar-git-fork-tobiasandersen-fix-default-placeholder-timc.vercel.app

vercel[bot] avatar Apr 23 '22 10:04 vercel[bot]

Fixed as part of https://github.com/timc1/kbar/commit/3d1c4c7451d37ff15313b58e9b6689f6cd0fd887

timc1 avatar Aug 25 '22 21:08 timc1