GitSavvy icon indicating copy to clipboard operation
GitSavvy copied to clipboard

Show staged lines/hunks in inline diff

Open p3lim opened this issue 9 years ago • 2 comments

When launching the inline diff the unstaged lines/hunks are marked in red/green, but once they are staged and you want to unstage them again (with capital hotkeys) it's hard to know what can be unstaged unless memorized.

I suggest using a yellow/orange color to highlight staged lines/hunks.

p3lim avatar Jul 13 '16 19:07 p3lim

I think this one has come up before too, and I'm very hesitant to move forward with it. The inline diff views are easily comprised of the most complex pieces of GitSavvy. Adding something like this would probably necessitate a complete rewrite of the feature. Honestly, that might be worth it, since we have a better grasp of the end goals and hopefully a better understanding of how it works under the hood.

As an interim option, we could also make it easier to get to the inline diff (cached) view for the same file. Say, pressing Tab or something, and where it would take you to the same line. That's not exactly what you're asking for, but it may help with knowing what you've staged/unstaged.

Also, are you saying that you're able to unstage hunks from the inline diff view that are not visible, by pressing a capital hotkey of some sort? If so, that's probably a bug!

divmain avatar Jul 14 '16 06:07 divmain

Also, are you saying that you're able to unstage hunks from the inline diff view that are not visible, by pressing a capital hotkey of some sort? If so, that's probably a bug!

No no, just saying that it's hard to tell what is staged, I was just being explicit in my report :)

p3lim avatar Jul 14 '16 06:07 p3lim