GitSavvy icon indicating copy to clipboard operation
GitSavvy copied to clipboard

Inline diff multiple (or all) files

Open alextegelid opened this issue 10 years ago • 4 comments

I just thought of a feature while cleaning up a lot of small corrections in quite a few files. Would it be possible to inline diff multiple (or all) files? And would it be of any use?

alextegelid avatar Dec 01 '15 13:12 alextegelid

Because the implementation for the inline diff view is very complex, adding this feature seems like a sizable risk. So unless there's an undeniable use-case with no alternative, I'm going to give a pretty firm "no" to this. However, maybe we can add a different feature to address the need.

For example, we added Tab functionality to cycle through dashboards. We could conceivably add Tab functionality to the inline diff view, to cycle through any other files that have changes (in the working dir when in default mode, and in the index when in cached mode).

Given the task that prompted this issue, would that have been useful? If not, can you enumerate some of the pain points with the current feature set? I'm definitely happy to take a look at this from that angle.

divmain avatar Dec 05 '15 10:12 divmain

Sounds like another possible solution to part of #311 (seeing all the diffs between this branch and master). Personally I think I would prefer tabbing through different diffs, rather than seeing them all end to end in one file.

stevage avatar Dec 08 '15 00:12 stevage

:+1: I like the idea of hitting tab to continue to next file. Though it may get confusing if you have both staged and unstaged lines in the same files.

edit: what @stoivo said!

asfaltboy avatar Dec 10 '15 10:12 asfaltboy

Maybe we should use s for switching between file that is available for inline diff? Than when you press s you will open a panel where we can fuzzy type to find the file we want. Bad idea?

I personally don`t like tabbing since I never remember the order of files

stoivo avatar Dec 10 '15 12:12 stoivo