starter-theme icon indicating copy to clipboard operation
starter-theme copied to clipboard

Use v2 API

Open naderabbara opened this issue 2 years ago • 4 comments

Replaces the deprecated class and functions. As is, the 2.x branch doesn't initialize properly or follow 2.x convention.

https://timber.github.io/docs/v2/upgrade-guides/2.0/

naderabbara avatar Jul 21 '22 17:07 naderabbara

Thank you!

Please update PR title to Use v2 API

szepeviktor avatar Jul 21 '22 17:07 szepeviktor

Thank you!

Please update PR title to Use v2 API

No problem, done!

naderabbara avatar Jul 21 '22 18:07 naderabbara

This looks right to me, @gchtr does this conform to preferred style?

jarednova avatar Jul 22 '22 17:07 jarednova

Also merged #132 into this PR as they're sort of one in the same.

@gchtr had a chance to review?

naderabbara avatar Sep 02 '22 15:09 naderabbara

@naderabbara @jarednova Looks good, thanks for these updates!

gchtr avatar Oct 11 '22 18:10 gchtr