subdir-heroku-buildpack icon indicating copy to clipboard operation
subdir-heroku-buildpack copied to clipboard

Build is not aborted if an error occurs

Open edmorley opened this issue 3 years ago • 0 comments

If an error occurs during the compile of this buildpack, the build continues on regardless rather than failing, since the bash error on exit mode is not enabled.

For improved reliability, it would be great to add a set -e, or even better, set -euo pipefail.

See also: http://redsymbol.net/articles/unofficial-bash-strict-mode/

Many thanks :-)

edmorley avatar Mar 01 '21 12:03 edmorley