bodyclose

bodyclose copied to clipboard

Returning *http.Response to another function is not handled correctly

3

Here is the sample code to reproduce: ```go package main import ( "net/http" ) func getResponse(url string) *http.Response { res, _ := http.Get(url) return res } func main() { resp...

mkfsn

false positive when close is in another package

1

The following code triggers a false positive. ```golang package util import ( "io" "log" ) func Close(c io.Closer) { if err := c.Close(); err != nil { log.Printf("error closing io:...

vasyharan

scop

``` var resp *http.Response func testGlobal() { resp, _ = http.Get("https://example.com") resp.Body.Close() } ``` It cause panic when check this code. ``` ERRO [runner] Panic: bodyclose: package "main" (isInitialPkg: true,...

woniu317

False positive with body close inside separate function

11

I think that bodyclose produces false positive warning on this code: response body is closed in a separate function inside each logic case. I can not use defer response.Body.Close() due...

renta

guonaihong

revive is so hot now https://github.com/mgechev/revive what about beinig a part of it?

WeDodoCite

false positive on first class function

1

### summary Similar to #18, when the `http.Response.Body.Close` method is extracted and called, `bodyclose` misses the call and incorrectly warns: ```go resp, err := http.Get("http://example.com/") if err != nil {...

carnott-snap

The following code is fine, because it closes the body only when the error is `nil`, but gets `response body must be closed` errors on both the `d.client.Do(req)` lines. ```go...

mostafah

false positive: if statement confuses linter

1

This program ``` package main import ( "net/http" ) func main() { var resp *http.Response var fizz bool if fizz { resp, _ = foo() } else { resp, _...

variadico