Tim Adye
Tim Adye
@HadrienG2 followed up on Mattermost, which I copy here: Glad to see that you sorted this out! Just to clarify one point... > In this case, it breaks at a...
Sorry, I was away. I'll take a look today.
Are you planning to include a CSV *reading* tool? Apart from providing another good format, that would be useful to test this by writing and reading back. I see there's...
Does this have a different interface compared to `Examples/Io/Root/include/ActsExamples/Io/Root/RootBFieldWriter.hpp`? It looks like this has the `CsvBFieldWriter::CoordinateType` coded as a template parameter, rather than an `enum Config::gridType`. That could be an...
I still had one issue outstanding, [here](https://github.com/acts-project/acts/pull/1470#discussion_r963005185). I hope @stephenswat can check that. The definitive check would be to read the ATLAS B-field, write with this PR, and check the...
> I have incorporated Tim's patches, and marked him appropriately as a co-author of the commits. Thanks @stephenswat! This looks good to me. I guess you will make the other...
> @timadye I noticed that `acts.examples.dump_args_calls(locals())` will fail the CI somehow when multiple pytests run in a row. this didn't happen before because it was not called. do you know...
> the problem is that after wrapping `isinstance` will not work anymore and this is used quite a lot in the python unit tests. Yes, `isinstance` checks for wrapped classes...
Otherwise looks good to me. When we have resolved the question about `minLevel` and `maxLevel` (just docs, I think), I think we can approve. Should I press the button?
Label WiP because it may take some time for deal with the fallout from a unit test failure. The ATLAS B-field mostly works fine because the under/overflow bins all have...