json-api icon indicating copy to clipboard operation
json-api copied to clipboard

Published 20 hours ago • verified publisher icon timacdonald

JsonApiServerImplementation 'final'`, doesn't allow custom implementations

Open GeoSot opened this issue 1 year ago • 2 comments

JsonApiServerImplementation class is a simple DTO that keeps jsonapi server information. There are cases, where some schemas need to declare some profiles etc. Unfortunately, the usage of final keyword, prevents any extension in order to support profile & extension properties. It would be fine to either remove the final keyword, or support the extra properties JSON:API defines https://github.com/timacdonald/json-api/blob/5c7f28bdc46ba078e2d8bfda307130095931a9a5/src/JsonApiServerImplementation.php#L10

GeoSot avatar Jun 07 '23 09:06 GeoSot

@timacdonald Can you help fixing this or propose a way in order to open a PR? Any help will be appreciated

GeoSot avatar Jun 12 '23 15:06 GeoSot

I would say that we should add support for those properties on the JsonApiServerImplementation class the package ships with.

timacdonald avatar Mar 13 '24 01:03 timacdonald