json-api icon indicating copy to clipboard operation
json-api copied to clipboard

Package requires Laravel framework instead of Illuminate packages

Open DannyvdSluijs opened this issue 3 years ago • 2 comments

As highlighted in composer.json https://github.com/timacdonald/json-api/blob/c3f89eef3e6c3e6b4f46321211543acc99f5134f/composer.json#L20 this package requires laravel/framework.

Trying to use this package in a Luman application is resulting in Illuminate packages being removed and laravel/framework being installed as its replacement causing some application issues.

I think it would be relatively easy to replace the dependencies for the sub packages of Laravel framework. Before creating such an PR I wanted to check if you would be accepting pull requests for this?

DannyvdSluijs avatar Apr 28 '22 18:04 DannyvdSluijs

I should be able to do this for sure. Will look at that shortly.

timacdonald avatar Jun 23 '22 06:06 timacdonald

I took the time to at least make the code changes that I think should be required in order to support Lumen. Changes still need to be tested.

DannyvdSluijs avatar Jul 13 '22 19:07 DannyvdSluijs

Gonna close this one and track in the PR. Thanks!

timacdonald avatar Aug 13 '22 01:08 timacdonald