Tim MacDonald comments

Results 167 comments of


                                            Tim MacDonald

Using multiple scopes across features disables use of `all()` and `values()`

Gonna close this one as we have this PR nearly ready to roll: https://github.com/laravel/pennant/pull/121

[1.x] Adds `Feature::activeForAny()`

@cosmastech, thinking out loud here, I feel like the API we really want here is something like this: ```php Feature::forSome($schools)->active('enrolled-in-beta'); ``` This better indicates that the "some" applies to the...

[1.x] Adds `Feature::activeForAny()`

@cosmastech, I don't think all methods would be available. Only a subset of methods would be available after calling `forSome`. I'm on something else at the moment, but will circle...

[1.x] Adds `Feature::activeForAny()`

@cosmastech, I'm going to close this one. This isn't a "no", more a "maybe later". I don't think this is the API we want and we also want to see...

Fix/add dot notation types to data object

@anned20, I'm not sure what this PR does. Can you please elaborate on what you are trying to achieve with it?

Fix/add dot notation types to data object

@anned20, appreciate the work you have done here. I'm not sure we want to support this right now until I see some more demand for the feature. As a side...

Add return type for useForm in laravel-precognition-vue-inertia

@ncphillips, Taylor has marked it as draft so I can review the PR. I am currently working on the async validate PR and once that is merged I will be...

Add return type for useForm in laravel-precognition-vue-inertia

@ncphillips, would you mind taking a quick look at my changes and let me know any concerns or thoughts? If you are happy, I'll open the PR for Taylor to...

Add return type for useForm in laravel-precognition-vue-inertia

Thank you, @ncphillips

Extended original InertiaJS props and method types into PrecognitionFormProps

Thanks, @juanparati. I'm gonna review this one shortly. Appreciate your work here.