Tim Abbott
Tim Abbott
This is great, huge thanks for doing this refactoring @PIG208! I added a couple refactoring commits that I think make both of the extracted decorator functions easier to read and...
Merged, thanks for doing this important refactor @PIG208!
I merged the two commits that aren't the stream shortcuts one; @synicalsyntax or @lonerz might be a good person to review that last commit (feel free to rebase to simplify...
I'm not sure we want to change all red to black; some of these may be marked red because the change is dangerous or whatever. This may require some careful...
We already handle the case of the server failing the response in a somewhat reasonable way.
@mahimg it looks like you did something wrong with Git; can you do a `git rebase upstream/master` to fix this?
Took a look at this -- one problem that I see is that one can have multiple messages in-flight at any given time. So I think we need to replace...
@mahimg thanks for working on this! The current version is buggy. Here's how I tested this: ``` diff --git a/zerver/lib/actions.py b/zerver/lib/actions.py index c2a8cfc..73890e5 100644 --- a/zerver/lib/actions.py +++ b/zerver/lib/actions.py @@ -715,6...
I did a thorough read through the code, and I think the structure should be somewhat different. Here's my proposal: * The code and data structures for this should live...
You probably hadn't seen my reply just now, but `echo.process_from_server` is the place to do that, since it already checks for locally-echoed messages.