Tim Schilling

Results 420 comments of Tim Schilling

> What can't we do, today, that we need to do, with the "Django Security Team", that we suddenly could do if it became the "DSF Security Working Group"? The...

Hi @django/django-security-team, please hold off on further reviews temporarily. The scope in this PR is broader than what is intended for the work coming out of #28. I'd like the...

@thibaudcolas or @robhudson can you close this PR please? I'm working on a replacement.

Not a nitpick at all. It's a good question @salty-ivy! My instinct is to go with `@property` to be consistent with the others. @matthiask thoughts?

TIL, then let's go with what Matthias suggested. Thank you for pointing that out

I wanted the autodoc and then thought it would bring consistency to the API. Though you and @salty-ivy both questioning it is enough for me to agree to having it...

@salty-ivy it can be hard to read the docs failures: ``` architecture.rst:84: : Spell check: ASGI: are disabled by default when running in async/ASGI enviroment.. architecture.rst:84: : Spell check: enviroment:...

See! I didn't even catch that other one. I thought it was two lines because the word was used twice on that line :grin:

I squashed the commits down to one, cleaned up the commit message, and rebased on main. After tests pass, I'll merge it in