Tim Schilling comments

Results 420 comments of


                                            Tim Schilling

Utilize pre-commit, black, isort and doc8

@medmunds thank you for the quality review. I haven't forgotten about this. My OSS availability is weaning a bit, but I'll try to address this over the weekend.

RemovedInDjango40Warning thrown by pytest

Confirmed that it's fixed. I can't close the issue though.

Unexpected argument force in url()

I don't believe this is an issue. When the system uses the manifest storage class, the toolbar's class inherits from it. If this is still an issue, please provide some...

Utilize pre-commit, black, isort and doc8

Thank you for maintaining the package and seeing this one through!

Why not pass authorize code/access_token when oauth2/callback redirect to LOGIN_REDIRECT_URL?

That token (`request.GET.get('code')`) is a one-time use token. To get the long lasting token from `AdfsAuthCodeBackend.authenticate` / `AdfsBaseBackend.exchange_auth_code`. I would imagine the token you actually want is the one that...

Why not pass authorize code/access_token when oauth2/callback redirect to LOGIN_REDIRECT_URL?

@JonasKs we do already. It's in `adfs_response` dict in the signal. The receiver needs to pull it out of the dict.

Why not pass authorize code/access_token when oauth2/callback redirect to LOGIN_REDIRECT_URL?

No worries, I didn't explain it very well.

Why not pass authorize code/access_token when oauth2/callback redirect to LOGIN_REDIRECT_URL?

> the access_token would expire about 1hour and need to refresh or query again, can this package also support to update access_token? I'm not sure I understand what you want...

Improve accessibility of the toolbar

Sounds good, I'll bring it up with the group next week and let you know. We'll probably take some of the logistical discussion offline, but put the long term stuff...

HistoricalForeignKey chasing through prev_record instance

Can you include the models that were used for this example?