obsidian-bible-reference icon indicating copy to clipboard operation
obsidian-bible-reference copied to clipboard

Does not work on mobile

Open ickc opened this issue 2 years ago • 7 comments

https://github.com/tim-hub/obsidian-bible-reference/blob/master/manifest.json#L9 seems to indicate that it would work on mobile, but when testing it on iPad and iPhone, it doesn't seem to work. Any idea? Thanks.

ickc avatar Aug 20 '22 00:08 ickc

I would like to +1 this as it works fine on my Mac but nothing seems to happen on my iPhone. This would be fantastic on my phone as I take notes in church and this would be a great way to import the scripture references.

russbonchu avatar Aug 20 '22 23:08 russbonchu

I am using Obsidian 1.3.1 (67) which is the latest version, and the plugin is up to date. i have tried several Bible versions and nothing happens. I would love to be able to use this in church with sermon notes.

russbonchu avatar Aug 26 '22 14:08 russbonchu

Oh, I haven't gotten an iOS device for testing, I only tried on Android, and it worked as on desktop, I am not sure, is it possible related to any iOS app policy?

tim-hub avatar Sep 02 '22 05:09 tim-hub

There's no policy that I'm aware of but not being a developer myself I could be wrong. I can do some research and check.

Thanks for looking into this, and thanks for creating this plugin!

— Russell Bonchu, III @.*** https://russbonchu.site 2163751801

On Friday, Sep 02, 2022 at 1:24 AM, Tim @.*** @.***)> wrote:

Oh, I haven't gotten an iOS device for testing, I only tried on Android, and it worked as on desktop, I am not sure, is it possible related to any iOS app policy?

— Reply to this email directly, view it on GitHub (https://github.com/tim-hub/obsidian-bible-reference/issues/55#issuecomment-1235079143), or unsubscribe (https://github.com/notifications/unsubscribe-auth/A2QCNWYVYNPTHDWYZ43MI5LV4GFRBANCNFSM57CKF72Q). You are receiving this because you commented.Message ID: @.***>

russbonchu avatar Sep 03 '22 15:09 russbonchu

Api:bible api can work on the phone,but API:Bolls can’t

sword218 avatar Oct 10 '22 23:10 sword218

3A7AA120-F268-4BAE-A9A5-54153AC2E632

sword218 avatar Oct 10 '22 23:10 sword218

57121591-0455-4DC6-B3F9-B44F9626CE7E

sword218 avatar Oct 10 '22 23:10 sword218

I can't seem to get either API working for me at the moment.

Edit: on iOS 15. iPhone 11

BMonsalvatge avatar Dec 04 '22 20:12 BMonsalvatge

Just tested this out on my Pixel 6 Pro and ran into the same issue. Bible API works fine but Bolls does not. We'll have to see if there are any functions or something that aren't supported on Android.

Is anyone able to confirm if Bible API works for Apple devices? Or does neither work?

JPT62089 avatar Jan 09 '23 02:01 JPT62089

Ok I was finally able to get some time to look into this further. On Android this appears to be an issue only with Bolls Life. The request is getting blocked by CORS policy as seen in the screenshot.

image

Access to fetch at 'https://bible-api-bff.bai.uno/bolls-life/ESV/43/1/' from origin 'http://localhost' has been blocked by CORS policy: The 'Access-Control-Allow-Origin' header has a value 'app://obsidian.md' that is not equal to the supplied origin. Have the server send the header with a valid value, or, if an opaque response serves your needs, set the request's mode to 'no-cors' to fetch the resource with CORS disabled.

@tim-hub, any reason why this is using https://bible-api-bff.bai.uno/bolls-life rather than https://bolls.life/get-text for the API URL? I changed my local main.js to the latter and it immediately worked perfectly on my android phone. In the meantime I might spin up a PR a change to the latter in case we want to switch to it over the current url

JPT62089 avatar Jan 11 '23 05:01 JPT62089

Ok I was finally able to get some time to look into this further. On Android this appears to be an issue only with Bolls Life. The request is getting blocked by CORS policy as seen in the screenshot.

image

Access to fetch at 'https://bible-api-bff.bai.uno/bolls-life/ESV/43/1/' from origin 'http://localhost' has been blocked by CORS policy: The 'Access-Control-Allow-Origin' header has a value 'app://obsidian.md' that is not equal to the supplied origin. Have the server send the header with a valid value, or, if an opaque response serves your needs, set the request's mode to 'no-cors' to fetch the resource with CORS disabled.

@tim-hub, any reason why this is using https://bible-api-bff.bai.uno/bolls-life rather than https://bolls.life/get-text for the API URL? I changed my local main.js to the latter and it immediately worked perfectly on my android phone. In the meantime I might spin up a PR a change to the latter in case we want to switch to it over the current url

In the beginning of trying bolls like api, I found there was a CORS error stopping the plugin to consume it,

But it looks like the issue is gone now.

Thanks for raising up and testing on this. :)

tim-hub avatar Jan 31 '23 09:01 tim-hub

Thanks @JPT62089 for the PR

https://github.com/tim-hub/obsidian-bible-reference/pull/73

the issues supposed to be fixed in release 1.4.0

tim-hub avatar Jan 31 '23 09:01 tim-hub

the issues supposed to be fixed in release 1.4.0 after PR #73

tim-hub avatar Jan 31 '23 09:01 tim-hub