tilt icon indicating copy to clipboard operation
tilt copied to clipboard

performance problems with large filewatch objects

Open nicks opened this issue 2 years ago • 0 comments

Repro Steps

  • Create a Tiltfile in a go project with lots of dependencies
  • Run go mod vendor

Current Behavior

tilt creates a very large FileWatch object in-memory

this slows down all operations, e.g.,

time tilt get filewatch -o yaml | tail -n 3
kind: List
metadata:
  resourceVersion: ""

real	0m0.729s
user	0m0.763s
sys	0m0.071s

even though all the data in the filewatch is never used

We should try to consolidate that data.

Additional context Probably the simplest way to do this would be to add a new field, like "DirectoriesChanged", for consolidating lots of FilesChanged in a single directory.

nicks avatar Dec 13 '23 22:12 nicks