tilt icon indicating copy to clipboard operation
tilt copied to clipboard

Binary for OSX has `mac` as binary name which would be nice if it would be `darwin`

Open Skarlso opened this issue 3 years ago • 3 comments

The binary name for OSX builds is tilt.0.23.9.mac.arm64.tar.gz. This doesn't meet standard binary naming schemes such as GOOS.GOARCH. or OS.ARCH. Because OS for OSX is actually darwin so we have to do some if...then hacks to automatically find the right binary.

This isn't a breaking thing, but would be nice if the naming would be consistent with OS naming. :) Thanks!

Skarlso avatar Feb 02 '22 08:02 Skarlso

HA. thanks for reporting.

ya, this is deliberate. https://github.com/tilt-dev/tilt/blob/master/.goreleaser.yml#L39

as i recall, this is a fairly divisive issue in the goreleaser user community because GOOS (and go devs in general) tend to use darwin, but other ecosystems (e.g., Homebrew) tend to use mac

https://goreleaser.com/customization/archive/

I don't have a strong preference between them, but changing it at this point would definitely break people's existing tilt install scripts.

nicks avatar Feb 02 '22 17:02 nicks

Understandable. Love the unfortunate label. :D

Skarlso avatar Feb 02 '22 19:02 Skarlso

this was confusing to me as well. I'm not familiar with the debate or the use of mac. It seems the eco system we are in is kubernetes, docker, kind etc. All of them use darwin. Should we consider aligning with that? or has the train left the station?

https://github.com/helm/helm/releases https://github.com/docker/compose-cli/releases https://github.com/kubernetes-sigs/kind/releases https://github.com/kudobuilder/kuttl/releases/

kensipe avatar Feb 02 '22 23:02 kensipe