tilt-extensions icon indicating copy to clipboard operation
tilt-extensions copied to clipboard

helm_resource should allow an array of values for set

Open chrisjohnson opened this issue 2 years ago • 5 comments

Many helm_remote and helm calls rely on arrays of set values. If helm_resource could accept that same array it would simplify interopability

chrisjohnson avatar Apr 01 '22 05:04 chrisjohnson

From the README:

flags: Additional flags to pass to helm install (e.g., ['--set', 'key=value'])

is that what you're looking for?

nicks avatar Apr 01 '22 14:04 nicks

With helm_remote I can do set=helm_values where helm_values is

[
  'image.tag=%s' % foo,
  'environment.name=development',
  'foo.bar=baz'
]

I would similarly like to be able to pass set values as an array, as opposed to composing the --set a=b args myself. It would just make adoption much simpler since the "array of set strings" pattern is so widely used already

chrisjohnson avatar Apr 01 '22 16:04 chrisjohnson

i guess we'd accept a PR to translate helm_resource(set=...) to the appropriate flags.

i'm usually a bit skeptical of having two ways to do the same thing, but ya, this would make adoption from helm() easier.

nicks avatar Apr 01 '22 23:04 nicks

helm_remote also allows a value.yaml file. Is this then also possible with helm_resource?

ManAnRuck avatar Jul 14 '22 07:07 ManAnRuck

@ManAnRuck

helm_resource(..., flags=['--values=./path/to/values.yaml'])

nicks avatar Jul 14 '22 22:07 nicks